gh-119180: Avoid going through AST and eval() when possible in annotationlib#124337
Merged
JelleZijlstra merged 11 commits intopython:mainfrom Sep 25, 2024
Merged
gh-119180: Avoid going through AST and eval() when possible in annotationlib#124337JelleZijlstra merged 11 commits intopython:mainfrom
JelleZijlstra merged 11 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Often, ForwardRefs represent a single simple name. In that case, we can avoid going through the overhead of creating AST nodes and code objects and calling eval(): we can simply look up the name directly in the relevant namespaces.
This PR incorporates the changes from #124326 (which fixes a bug that I discovered while working on this change).